Hi Sam,
On 25/07/2023 22:21, Sam Edwards wrote:
Hi Andre,
Series looks good so far! I'm trying to move my testing build over to it
now; I will report back when I've been running on it for a little bit.
Cool, thanks!
On 7/21/23 07:45, Andre Przywara wrote:
diff --git a/board/sunxi/board.c b/board/sunxi/board.c
index 7ac50c4ae8c..2db4a2d73ca 100644
--- a/board/sunxi/board.c
+++ b/board/sunxi/board.c
@@ -187,7 +187,7 @@ enum env_location env_get_location(enum
env_operation op, int prio)
/* add board specific code here */
int board_init(void)
{
- __maybe_unused int id_pfr1, ret, macpwr_pin;
+ __maybe_unused int id_pfr1, ret;
gd->bd->bi_boot_params = (PHYS_SDRAM_0 + 0x100);
@@ -224,15 +224,6 @@ int board_init(void)
if (ret)
return ret;
- /* strcmp() would look better, but doesn't get optimised away. */
- if (CONFIG_MACPWR[0]) {
- macpwr_pin = sunxi_name_to_gpio(CONFIG_MACPWR);
- if (macpwr_pin >= 0) {
- gpio_request(macpwr_pin, "macpwr");
- gpio_direction_output(macpwr_pin, 1);
- }
- }
This version of your series does not include the CONFIG_SATAPWR removal
(is that intentional or did you miss it?) so these hunks do not apply
against master. I was able to cherry-pick the rc series version of the
CONFIG_SATAPWR removal and everything applied fine. Just thought you
should know!
Ah, thanks for the heads up! It's actually the first patch, but I
apparently had an off-by-one on the git format-patch command line.
The gitlab repo has the patch:
https://source.denx.de/u-boot/custodians/u-boot-sunxi/-/commits/t113s/
I will send it separately later today.
Cheers,
Andre
