Hi Rick, On Wed, 19 Apr 2023 at 00:56, Rick Chen <rickche...@gmail.com> wrote: > > Hi Simon, > > > Hi Rick, > > > > On Mon, 10 Apr 2023 at 01:26, Rick Chen <r...@andestech.com> wrote: > > > > > > Allow U-Boot to load 32 or 64 bits RISC-V Kernel Image > > > distinguishly. It helps to avoid someone maybe make a mistake > > > to run 32-bit U-Boot to load 64-bit kernel. > > > > > > Signed-off-by: Rick Chen <r...@andestech.com> > > > > > > --- > > > The patchset is based on Simon's patch: > > > riscv: Add a 64-bit image type > > > --- > > > --- > > > arch/riscv/include/asm/u-boot.h | 4 ++++ > > > cmd/booti.c | 2 +- > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > Reviewed-by: Simon Glass <s...@chromium.org> > > > > I don't know much about RISC-V, but I assume U-Boot is able to do this > > successfully? Does it not need to switch modes first? > > No, it is not need to switch modes as far as I know. > Here only provide a check mechanism just like arm to see if loader and > OS are match > > But This patch is for bootm flow. > Maybe I still need to check if it is necessary to prepare a patch for > binman flow ? > /arch/riscv/dts/binman.dtsi > arch = "riscv"; > > maybe provide another binman64.dtsi for arch="riscv64"
Yes I think that is needed too. Are you going to update this patch, or send a second one? Regards, Simon