On Tuesday, February 15, 2011 19:51:00 Scott Wood wrote:
> On Tue, 15 Feb 2011 04:02:44 -0500 Mike Frysinger wrote:
> > > This included anything that cpu/board code added to LDFLAGS -- some
> > > architectures added --gc-sections, x86 added --cref, etc.  Since the
> > > above flags are added to LDFLAGS, rather than replacing them, these
> > > flags got used in the final link.
> > > 
> > > Commit 8aba9dc introduces LDFLAGS_u-boot, so that LDFLAGS is no longer
> > > the source for the flags for the final link.  It generates
> > > LDFLAGS_u-boot using PLATFORM_LDFLAGS, not LDFLAGS.  It converts most
> > > of the board/cpu updates to LDFLAGS into LDFLAGS_u-boot, but it missed
> > > --cref.
> > 
> > err, i dont think this is correct.  LDFLAGS is no longer the *only*
> > source for the final link.  if you look at the actual target, you'll see
> > it using $(LDFLAGS) $(LDFLAGS_$(@F)).
> 
> Ah.  So why is PLATFORM_LDFLAGS added into both LDFLAGS and
> LDFLAGS_u-boot? :-P

i'm not saying PLATFORM_LDFLAGS makes sense.  it certainly seems like we've 
outgrown the PLATFORM_XXX flags and could be cleaned up.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to