On Mon, Jul 31, 2023 at 09:43:29PM +0300, Sergei Antonov wrote:

> Support for NPort 6600 Series RS-232/422/485 secure terminal servers.
> 
> Technical specifications:
> FA526 ARMv4 CPU, 64 MB of RAM, 16 MB NOR flash, 100 Mbit/s Ethernet,
> optional expansion modules, up to 32 RS-232/422/485 ports.
> 
> Signed-off-by: Sergei Antonov <sap...@gmail.com>
> ---
>  arch/arm/Kconfig                 |   9 +++
>  arch/arm/dts/nport6600.dts       | 134 +++++++++++++++++++++++++++++++

Where does the device tree come from?

> diff --git a/board/moxa/nport6600/nport6600.c 
> b/board/moxa/nport6600/nport6600.c
> new file mode 100644
> index 000000000000..88fa98c315fd
> --- /dev/null
> +++ b/board/moxa/nport6600/nport6600.c
> @@ -0,0 +1,78 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +
> +#include <common.h>

New files must not add common.h

> diff --git a/include/configs/nport6600.h b/include/configs/nport6600.h
> new file mode 100644
> index 000000000000..c70cc7e1ac72
> --- /dev/null
> +++ b/include/configs/nport6600.h
[snip]
> +#define __io

What's this for?

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to