On Wed, Aug 02, 2023 at 03:31:22PM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 2 Aug 2023 at 09:10, Tom Rini <tr...@konsulko.com> wrote: > > > > It is not a parse error to have a default value of "0" for a "hex" type > > entry, instead of "0x0". However, "0" and "0x0" are not treated the > > same even by the tools themselves. Correct this by changing the default > > value from "0" to "0x0" for all hex type questions that had the > > incorrect default. Fix one instance (in two configs) of a default of "0" > > being used on a hex question to be "0x0". Remove the cases where a > > defconfig had set a value of "0x0" to be used as the default had been > > "0". > > > > Signed-off-by: Tom Rini <tr...@konsulko.com> > > --- > > arch/arm/cpu/armv7/ls102xa/Kconfig | 1 - > > arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 2 +- > > arch/arm/mach-imx/Kconfig | 2 +- > > arch/arm/mach-imx/imx8/Kconfig | 4 ++-- > > arch/arm/mach-rockchip/Kconfig | 2 +- > > arch/arm/mach-sunxi/Kconfig | 4 ++-- > > arch/powerpc/cpu/mpc8xx/Kconfig | 2 +- > > boot/Kconfig | 2 +- > > cmd/Kconfig | 8 ++++---- > > common/Kconfig | 2 +- > > common/spl/Kconfig | 2 +- > > common/spl/Kconfig.tpl | 2 +- > > configs/am335x_guardian_defconfig | 1 - > > configs/efi-x86_app32_defconfig | 2 +- > > configs/efi-x86_app64_defconfig | 2 +- > > configs/evb-rk3229_defconfig | 1 - > > configs/evb-rk3308_defconfig | 1 - > > configs/imx6q_logic_defconfig | 1 - > > configs/imx8mm_data_modul_edm_sbc_defconfig | 1 - > > configs/imx8mn_beacon_2g_defconfig | 1 - > > configs/imx8mn_beacon_defconfig | 1 - > > configs/imx8mn_beacon_fspi_defconfig | 1 - > > configs/imx8mp_beacon_defconfig | 1 - > > configs/imx8mp_data_modul_edm_sbc_defconfig | 1 - > > configs/imx8mp_dhcom_pdk2_defconfig | 1 - > > configs/imx8mp_dhcom_pdk3_defconfig | 1 - > > configs/kontron_sl28_defconfig | 2 -- > > configs/lion-rk3368_defconfig | 1 - > > configs/roc-cc-rk3308_defconfig | 1 - > > configs/rock-pi-s-rk3308_defconfig | 1 - > > configs/sandbox64_defconfig | 1 - > > configs/sandbox_defconfig | 1 - > > configs/sandbox_flattree_defconfig | 1 - > > configs/sandbox_noinst_defconfig | 1 - > > configs/sandbox_spl_defconfig | 1 - > > configs/sandbox_vpl_defconfig | 1 - > > configs/xilinx_versal_net_virt_defconfig | 1 - > > configs/xilinx_zynqmp_virt_defconfig | 1 - > > drivers/block/Kconfig | 2 +- > > drivers/fastboot/Kconfig | 2 +- > > drivers/i2c/Kconfig | 16 ++++++++-------- > > drivers/misc/Kconfig | 2 +- > > drivers/serial/Kconfig | 6 +++--- > > drivers/usb/gadget/Kconfig | 2 +- > > drivers/video/Kconfig | 4 ++-- > > env/Kconfig | 4 ++-- > > lib/Kconfig | 2 +- > > 47 files changed, 38 insertions(+), 64 deletions(-) > > > > I'm not sure how you found all those, but it looks good to me from a spot > check.
Manually. It's thankfully not many cases of "default 0". > Can we have a checkpatch check? Sadly, no. But I think if we spent some time fixing other issues too, kconfiglib could be used as a tool to catch these. -- Tom
signature.asc
Description: PGP signature
