On Fri, Jul 14, 2023 at 01:24:50PM +0200, Matthias Schiffer wrote: > Both the Linux kernel and libbsd agree that strlcpy() should always > return strlen(src) and not include the NUL termination. The incorrect > U-Boot implementation makes it impossible to check the return value for > truncation, and breaks code written with the usual implementation in > mind (for example, fdtdec_add_reserved_memory() was subtly broken). > > I reviewed all callers of strlcpy() and strlcat() and fixed them > according to my understanding of the intended function. > > This reverts commit d3358ecc54be0bc3b4dd11f7a63eab0a2842f772 and adds > related fixes. > > Fixes: d3358ecc54be ("lib: string: Fix strlcpy return value") > Signed-off-by: Matthias Schiffer <matthias.schif...@ew.tq-group.com> > Reviewed-by: Simon Glass <s...@chromium.org> > Reviewed-by: Sean Anderson <sean.ander...@seco.com>
Applied to u-boot/next, thanks! -- Tom
signature.asc
Description: PGP signature