Hi, On Tue, Aug 15, 2023 at 12:45:57AM +0200, Marek Vasut wrote: > On 8/15/23 00:42, Simon Glass wrote: > > On Sun, 13 Aug 2023 at 15:47, Marek Vasut > > <marek.vasut+rene...@mailbox.org> wrote: > > > > > > Enable NVMXIP QSPI driver on sandbox, since it is already enabled > > > on sandbox64. Update blk tests to match. > > > > > > Signed-off-by: Marek Vasut <marek.vasut+rene...@mailbox.org> > > > --- > > > Cc: Abdellatif El Khlifi <abdellatif.elkhl...@arm.com> > > > Cc: Simon Glass <s...@chromium.org> > > > --- > > > configs/sandbox_defconfig | 1 + > > > test/dm/blk.c | 63 +++++++++++++++++++++++++++++++-------- > > > 2 files changed, 52 insertions(+), 12 deletions(-) > > > > > > > Reviewed-by: Simon Glass <s...@chromium.org> > > NAK, this one has to wait. All of this NVMXIP stuff needs closer look, I > think it is really weirdly broken and doesn't even pass sandbox and > sandbox64 tests. Can Abdellatif try and check whether ALL sandbox and > sandbox64 tests pass with this enabled ?
Initially the NVMXIP feature has been introduced with sandbox64 support. The test case runs fine on sandbox64. I've just sent a commit enabling NVMXIP for sandbox [1]. Tested on both sandbox and sandbox64. I hope this helps. [1]: https://lore.kernel.org/all/20230815164300.444701-1-abdellatif.elkhl...@arm.com/ Cheers Abdellatif