On Tue, Aug 15, 2023 at 8:33 AM Paul Liu <paul....@linaro.org> wrote: > > Hi Tom, > > Yes, I think Rasmus is correct. I didn't have any real cases that can trigger > the bug. > So let's don't include this patch. I'll see if I can revert this in AOSP's > branch. > > Yours, > Paul > > > > Y > > On Tue, 15 Aug 2023 at 22:42, Tom Rini <tr...@konsulko.com> wrote: >> >> On Thu, Mar 09, 2023 at 10:12:21AM +0800, Ying-Chun Liu (PaulLiu) wrote: >> >> > From: Tom Cherry <tomche...@google.com> >> > >> > vsnprintf_internal() adds 'size' to 'buf' and vsprintf() sets 'size' >> > to 'INT_MAX' which can overflow. This causes sprintf() to fail when >> > initializing the environment on 8GB. >> > >> > Instead of using 'INT_MAX', we use SIZE_MAX - buf, which is the >> > largest possible string that could fit without overflowing 'size'. >> > >> > Signed-off-by: Tom Cherry <tomche...@google.com> >> > [ Paul: pick from the Android tree. Rebase to the upstream ] >> > Signed-off-by: Ying-Chun Liu (PaulLiu) <paul....@linaro.org> >> > Cc: Tom Rini <tr...@konsulko.com> >> > Link: >> > https://android.googlesource.com/platform/external/u-boot/+/43aae5d4415e0f9d744fb798acd52429d09957ce >> >> So, this link here leads back to >> https://issuetracker.google.com/issues/200479053 which isn't public. >> >> Rasmus followed up and asked pointed questions, that weren't followed up >> on. >> >> -- >> Tom
Hi all, I hadn't seen the questions from Rasmus, and I haven't had much time to dig into why this issue happened. I'll try to get time for this in the upcoming weeks. I originally triggered this bug in a real-world use case. I was unable to boot my platform before this patch and I wrote this patch to solve that issue. I reverted that patch and tried booting my platform today and I am able to boot however I see error logs that are not present when this patch is applied (the below "Partition 1: invalid GUID"), which suggests that there are lingering issues, which I'll investigate. With the change: U-Boot 2023.04-maybe-dirty (Jan 01 1970 - 00:00:00 +0000) DRAM: 8 GiB Core: 8 devices, 8 uclasses, devicetree: separate Hit any key to stop autoboot: 0 ANDROID: Booting Unlocked!! ## Android Verified Boot 2.0 version 1.1.0 With the change reverted: U-Boot 2023.04-maybe-dirty (Jan 01 1970 - 00:00:00 +0000) DRAM: 8 GiB Core: 8 devices, 8 uclasses, devicetree: separate Hit any key to stop autoboot: 0 Partition 1: invalid GUID Partition 2: invalid GUID Partition 3: invalid GUID Partition 4: invalid GUID Partition 5: invalid GUID ANDROID: Booting Unlocked!! ## Android Verified Boot 2.0 version 1.1.0 Thanks Tom
