On 19/08/2023 15:39, Marek Vasut wrote:
> Clean the function up a bit further. Return immediatelly on match
> and return ARRAY_SIZE() - 1 on failure. Add proper comment in that
> case.
>
> Signed-off-by: Marek Vasut <marek.vasut+rene...@mailbox.org>
> ---
> Cc: Biju Das <biju.das...@bp.renesas.com>
> Cc: Paul Barker <paul.barker...@bp.renesas.com>
> ---
> arch/arm/mach-rmobile/cpu_info.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-rmobile/cpu_info.c
> b/arch/arm/mach-rmobile/cpu_info.c
> index 7651e43bd0f..6804b1da2cd 100644
> --- a/arch/arm/mach-rmobile/cpu_info.c
> +++ b/arch/arm/mach-rmobile/cpu_info.c
> @@ -83,14 +83,15 @@ static const struct {
>
> static int rmobile_cpuinfo_idx(void)
> {
> - int i = 0;
> u32 cpu_type = rmobile_get_cpu_type();
> + int i;
>
> - for (; i < ARRAY_SIZE(rmobile_cpuinfo) - 1; i++)
> + for (i = 0; i < ARRAY_SIZE(rmobile_cpuinfo) - 1; i++)
> if (rmobile_cpuinfo[i].cpu_type == cpu_type)
> - break;
> + return i;
>
> - return i;
> + /* Unknown "CPU" entry */
> + return ARRAY_SIZE(rmobile_cpuinfo) - 1;
> }
>
> static const u8 *get_cpu_name(int idx)Reviewed-by: Paul Barker <paul.barker...@bp.renesas.com>
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
