On 8/23/23 17:41, Bhupesh Sharma wrote:
Right now xhci header file defines XHCI_MAX_HALT_USEC macro
twice. Fix the same.

Cc: Bin Meng <bmeng...@gmail.com>

This Cc: ^ stufff

Signed-off-by: Bhupesh Sharma <bhupesh.sha...@linaro.org>
---

Should go here , below the ---

and then add another --- and the diffstat, i.e. this:

Commit
Message
Blah blah
Blah

Signed-of-by:...
---
Cc: Foo User <b...@example.com>
Cc: Another User ...
---
Changelog/Diffstat/patch

  include/usb/xhci.h | 2 --
  1 file changed, 2 deletions(-)

diff --git a/include/usb/xhci.h b/include/usb/xhci.h
index 4a4ac10229..958c94bfa7 100644
--- a/include/usb/xhci.h
+++ b/include/usb/xhci.h
@@ -1136,8 +1136,6 @@ void xhci_hcd_stop(int index);
  /*************************************************************
        EXTENDED CAPABILITY DEFINITIONS
  *************************************************************/
-/* Up to 16 ms to halt an HC */
-#define XHCI_MAX_HALT_USEC     (16*1000)
  /* HC not running - set to 1 when run/stop bit is cleared. */
  #define XHCI_STS_HALT         (1 << 0)

Reviewed-by: Marek Vasut <ma...@denx.de>

The patch is obviously correct, fix up the CC list and send a V2 please.

btw if you include the --- in commit message, git will retain the Cc: list below --- too.

Reply via email to