On Wed, Aug 30, 2023 at 07:31:51AM -0500, Nishanth Menon wrote: > On 17:14-20230829, Andrew Davis wrote: > > Add am62x_beagleplay_r5_defconfig for R5 SPL and > > am62x_beagleplay_a53_defconfig for A53 SPL and U-Boot support. > > > > These defconfigs are composite defconfigs built from the config fragment > > board/ti/am62x/beagleplay_*.config applied onto the base > > am62x_evm_*_defconfig. > > > > Signed-off-by: Andrew Davis <a...@ti.com> > > --- > > configs/am62x_beagleplay_a53_defconfig | 3 +++ > > configs/am62x_beagleplay_r5_defconfig | 3 +++ > > 2 files changed, 6 insertions(+) > > create mode 100644 configs/am62x_beagleplay_a53_defconfig > > create mode 100644 configs/am62x_beagleplay_r5_defconfig > > > > diff --git a/configs/am62x_beagleplay_a53_defconfig > > b/configs/am62x_beagleplay_a53_defconfig > > new file mode 100644 > > index 00000000000..ad708e15397 > > --- /dev/null > > +++ b/configs/am62x_beagleplay_a53_defconfig > > @@ -0,0 +1,3 @@ > > +// The BeaglePlay defconfig for A53 core > > +#include "configs/am62x_evm_a53_defconfig" > > +#include "board/ti/am62x/beagleplay_a53.config" > > diff --git a/configs/am62x_beagleplay_r5_defconfig > > b/configs/am62x_beagleplay_r5_defconfig > > new file mode 100644 > > index 00000000000..276b1f81a3e > > --- /dev/null > > +++ b/configs/am62x_beagleplay_r5_defconfig > > @@ -0,0 +1,3 @@ > > +// The BeaglePlay defconfig for R5 core > > +#include "configs/am62x_evm_r5_defconfig" > > +#include "board/ti/am62x/beagleplay_r5.config" > > -- > > 2.39.2 > > > > my only complaint is that if we add lets say > board/ti/am62x/dfu.config, Then: > > R5: > 1. am62x_evm_r5_defconfig = am62x_evm_r5_defconfig > 2. am62x_beagleplay_r5_defconfig = am62x_evm_r5_defconfig + > beagleplay_r5.config > 3. am62x_evm_r5_dfu_defconfig = am62x_evm_r5_defconfig + dfu.config > 4. am62x_beagleplay_r5_dfu_defconfig = am62x_evm_r5_defconfig + > beagleplay_r5.config + dfu.config > > This information can be in a single txt file Rather than have a > defconfig file for each combination.
I know Andrew is trying to do what Simon's asked. But yes, this is why I don't think the right approach is to have some file that says "here are all of the valid combinations". We aren't going to be breaking "make am62x_beagleplay_r5_dfu_defconfig local-fragment.config" in the above example. And we don't need every possible combination in CI, we just need to make sure unique paths are tested. So long as something builds all of the dts files, the Tegra example in-tree now is fine because we're checking all of those. The beagle examples here too should be fine. -- Tom
signature.asc
Description: PGP signature
