Hi Alper, On Wed, 30 Aug 2023 at 13:15, Alper Nebi Yasak <alpernebiya...@gmail.com> wrote: > > > > On 2023-08-21 22:11 +03:00, Simon Glass wrote: > > On Mon, 21 Aug 2023 at 07:51, Alper Nebi Yasak <alpernebiya...@gmail.com> > > wrote: > >> > >> From: Alexander Graf <ag...@csgraf.de> > >> > >> We are going to introduce image damage tracking to fasten up screen > >> refresh on large displays. This patch adds damage tracking for up to > >> one rectangle of the screen which is typically enough to hold blt or > >> text print updates. Callers into this API and a reduced dcache flush > >> code path will follow in later patches. > >> > >> Signed-off-by: Alexander Graf <ag...@csgraf.de> > >> Reported-by: Da Xue <da@libre.computer> > >> [Alper: Use xstart/yend, document new fields, return void from > >> video_damage(), declare priv, drop headers, use IS_ENABLED()] > >> Co-developed-by: Alper Nebi Yasak <alpernebiya...@gmail.com> > >> Signed-off-by: Alper Nebi Yasak <alpernebiya...@gmail.com> > >> --- > >> > >> Changes in v5: > >> - Use xstart, ystart, xend, yend as names for damage region > >> - Document damage struct and fields in struct video_priv comment > >> - Return void from video_damage() > >> - Fix undeclared priv error in video_sync() > >> - Drop unused headers from video-uclass.c > >> - Use IS_ENABLED() instead of CONFIG_IS_ENABLED() > >> > >> Changes in v4: > >> - Move damage clear to patch "dm: video: Add damage tracking API" > >> - Simplify first damage logic > >> - Remove VIDEO_DAMAGE default for ARM > >> > >> Changes in v3: > >> - Adapt to always assume DM is used > >> > >> Changes in v2: > >> - Remove ifdefs > >> > >> drivers/video/Kconfig | 13 ++++++++++++ > >> drivers/video/video-uclass.c | 41 +++++++++++++++++++++++++++++++++--- > >> include/video.h | 32 ++++++++++++++++++++++++++-- > >> 3 files changed, 81 insertions(+), 5 deletions(-) > >> > > > > Reviewed-by: Simon Glass <s...@chromium.org> > > > > But I suggest an empty static inline in the case where the feature is > > disabled?
> > You mean with something like #ifdef CONFIG_VIDEO_DAMAGE, right? Yes Regards, Simon