On 9/1/23 00:16, Jonas Karlman wrote:
The documentation for struct phy state that "The content of the
structure is managed solely by the PHY API and PHY drivers".

Change to use the generic_phy_valid() helper to check if phy is valid.

Fixes: f6f5451d469b ("scsi: ceva: Enable PHY and reset support")
Signed-off-by: Jonas Karlman <jo...@kwiboo.se>
---
  drivers/ata/sata_ceva.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/sata_ceva.c b/drivers/ata/sata_ceva.c
index 47366438fdfd..7769d4f99efd 100644
--- a/drivers/ata/sata_ceva.c
+++ b/drivers/ata/sata_ceva.c
@@ -217,7 +217,7 @@ static int sata_ceva_probe(struct udevice *dev)
                }
        }
- if (phy.dev) {
+       if (generic_phy_valid(&phy)) {
                dev_dbg(dev, "Perform PHY power on\n");
                ret = generic_phy_power_on(&phy);
                if (ret) {

Applied.
M

Reply via email to