On 13:06-20230906, Nishanth Menon wrote: > On 13:13-20230905, Reid Tonking wrote: > > The ti,j7200-vtm compatible is used for voltage and thermal monitoring > > (VTM) by (drivers/thermal/k3_j72xx_bandgap.c) in Linux, but the same > > hardware is used for adaptive voltage scaling (AVS) in u-boot, This brings > > both drivers in line with the same compatible. Since the j7200 uses the > > config as the j721e, the data is inherited from j721e vs creating a > > duplicate in all but name. > > > > Signed-off-by: Reid Tonking <re...@ti.com> > > --- > > drivers/misc/k3_avs.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/misc/k3_avs.c b/drivers/misc/k3_avs.c > > index 840148d090..f7936017ba 100644 > > --- a/drivers/misc/k3_avs.c > > +++ b/drivers/misc/k3_avs.c > > @@ -382,7 +382,7 @@ static struct vd_config am654_vd_config = { > > static const struct udevice_id k3_avs_ids[] = { > > { .compatible = "ti,am654-avs", .data = (ulong)&am654_vd_config }, > > { .compatible = "ti,j721e-avs", .data = (ulong)&j721e_vd_config }, > > - {} > > + { .compatible = "ti,j7200-vtm", .data = (ulong)&j721e_vd_config } > you don't need the null terminator? >
Ah, I wasn't aware of its purpose until now, but searched it up. I'll add it back in for v3. > > }; > > > > U_BOOT_DRIVER(k3_avs) = { > > -- > > 2.34.1 > > > https://lore.kernel.org/all/1fed9388-dfc4-0b9c-4502-b5020b2ae...@ti.com/ > > Will let Udit and you sort this out. Udit and I talked a bit about this yesterday. It's something to explore implementing down the road, after this sync - nothing immediate > -- > Regards, > Nishanth Menon > Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 > 849D 1736 249D Thanks, Reid Tonking