On Fri, Sep 1, 2023 at 3:13 AM Simon Glass <s...@chromium.org> wrote: > > Hi Tom, > > On Thu, 31 Aug 2023 at 11:48, Tom Rini <tr...@konsulko.com> wrote: > > > > On Thu, Aug 31, 2023 at 11:20:52AM -0600, Simon Glass wrote: > > > > > When building in a portage chroot, we do not have the environment needed > > > to build pylibfdt. It is instead build as a separate package. > > > > > > Provide a build option to tell U-Boot to skip this part of the build. We > > > still need it to use binman, etc. but don't need it to build its > > > dependencies. > > > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > > Reviewed-by: Mike Frysinger <vap...@chromium.org> > > > --- > > > > > > Makefile | 8 ++++++++ > > > > Can we do this via Kconfig instead? It looks like we don't need to do > > this part of the build for coreboot, yes? And so if we can drop it from > > other builds as well that might help speed up CI. > > Yes it could. But I really don't like changing the board config on the > fly - we have things like 'select BINMAN' now and it just gets messy. > In the normal course of events we want to build the python things and > the build won't work without it (e.g. binman will fail). But where the > build environment has installed binman separate, it knows better. > > So I don't think this is a board config thing, > > > > > [snip] > > > +The tools-only build bytes pylibfdt by default. To disable this, use the > > > > "build bytes" should probably be "builds" I suspect. > > Yes, thanks. >
Corrected "build bytes" to "builds bytes", and series applied to u-boot-x86/next, thanks! Regards, Bin