Hi Bin, On Tue, 19 Sept 2023 at 01:19, Bin Meng <bmeng...@gmail.com> wrote: > > Hi Simon, > > On Thu, Aug 24, 2023 at 5:11 AM Simon Glass <s...@chromium.org> wrote: > > > > This is very annoying as it is quite slow on many machines. Also, U-Boot > > has an existing 'preboot' mechanism to enable this feature if desired. > > > > Drop this code so that it is possible to choose whether to init USB or > > not. > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > --- > > > > (no changes since v1) > > > > arch/x86/cpu/coreboot/coreboot.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/arch/x86/cpu/coreboot/coreboot.c > > b/arch/x86/cpu/coreboot/coreboot.c > > index c2ceaa9a56c..567f1ab116c 100644 > > --- a/arch/x86/cpu/coreboot/coreboot.c > > +++ b/arch/x86/cpu/coreboot/coreboot.c > > @@ -86,10 +86,6 @@ static int last_stage_init(void) > > if (IS_ENABLED(CONFIG_SPL_BUILD)) > > return 0; > > > > - /* start usb so that usb keyboard can be used as input device */ > > - if (IS_ENABLED(CONFIG_USB_KEYBOARD)) > > - usb_init(); > > Dropping this causes USB keyboards to fail to be usable as the U-Boot > input device.
OK I will enable the normal USE_PREBOOT mechanism in v5 > > > - > > board_final_init(); > > > > return 0; > > -- Regards, Simon