Hi Masahisa, On Fri, 15 Sept 2023 at 04:17, Masahisa Kojima <masahisa.koj...@linaro.org> wrote: > > This introduces the valid range check to store the received > blocks using lmb. The same logic is implemented in tftp. > > Signed-off-by: Masahisa Kojima <masahisa.koj...@linaro.org> > --- > net/wget.c | 80 +++++++++++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 73 insertions(+), 7 deletions(-) >
Reviewed-by: Simon Glass <s...@chromium.org> > diff --git a/net/wget.c b/net/wget.c > index 2dbfeb1a1d..9690e4539c 100644 > --- a/net/wget.c > +++ b/net/wget.c > @@ -4,16 +4,20 @@ > * Copyright Duncan Hare <d...@synoia.com> 2017 > */ > > +#include <asm/global_data.h> > #include <command.h> > #include <common.h> > #include <display_options.h> > #include <env.h> > #include <image.h> > +#include <lmb.h> > #include <mapmem.h> > #include <net.h> > #include <net/tcp.h> > #include <net/wget.h> > > +DECLARE_GLOBAL_DATA_PTR; > + > static const char bootfile1[] = "GET "; > static const char bootfile3[] = " HTTP/1.0\r\n\r\n"; > static const char http_eom[] = "\r\n\r\n"; > @@ -55,6 +59,29 @@ static unsigned int retry_tcp_ack_num; /* TCP retry > acknowledge number*/ > static unsigned int retry_tcp_seq_num; /* TCP retry sequence number */ > static int retry_len; /* TCP retry length */ > > +static ulong wget_load_size; > + > +/** > + * wget_init_max_size() - initialize maximum load size > + * > + * Return: 0 if success, -1 if fails > + */ > +static int wget_init_load_size(void) > +{ > + struct lmb lmb; > + phys_size_t max_size; > + > + lmb_init_and_reserve(&lmb, gd->bd, (void *)gd->fdt_blob); That function should be changed to const void * but we plan to move to ofnode anyway, so let's not worry about it. [..] Regards, Simon