On mar., oct. 10, 2023 at 11:03, Miquel Raynal <miquel.ray...@bootlin.com> wrote:
> Today CMD_BIND defaults to 'y' when USB_ETHER is enabled. In practice, > CMD_BIND should default to 'y' when any USB gadget is enabled not only > USB_ETHER. Let's invert the logic of the dependency and use the weak > 'imply' keyword to enforce this. > > Signed-off-by: Miquel Raynal <miquel.ray...@bootlin.com> Tested that the bind command exists when building with: configs/khadas-vim3_android_defconfig Reviewed-by: Mattijs Korpershoek <mkorpersh...@baylibre.com> Tested-by: Mattijs Korpershoek <mkorpersh...@baylibre.com> # on vim3 > --- > cmd/Kconfig | 1 - > drivers/usb/gadget/Kconfig | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index 43ca10f69cc..6cc3bf6c2d0 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -996,7 +996,6 @@ config CMD_BCB > config CMD_BIND > bool "bind/unbind - Bind or unbind a device to/from a driver" > depends on DM > - default y if USB_ETHER > help > Bind or unbind a device to/from a driver from the command line. > This is useful in situations where a device may be handled by several > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > index 1cfe6022842..44f47a07207 100644 > --- a/drivers/usb/gadget/Kconfig > +++ b/drivers/usb/gadget/Kconfig > @@ -17,6 +17,7 @@ menuconfig USB_GADGET > bool "USB Gadget Support" > depends on DM > select DM_USB > + imply CMD_BIND > help > USB is a master/slave protocol, organized with one master > host (such as a PC) controlling up to 127 peripheral devices. > -- > 2.34.1
