Hi David,
It'd be good to include "smdk2410" in this patch titles, eg "smdk2410:
Various cleanups/code style fixes". or "arm: smdk2410: Various..."

Without the prefix, its unclear what code these patches affect, and
somewhat implies you are changing common code.

<snip>

> -#define      CONFIG_RTC_S3C24X0      1
> +#define      CONFIG_RTC_S3C24X0

Looks like there are a number of tabs in odd locations, it'd be nice to
clean those up while you're modifying this file.

Best,
Peter

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to