Am 26. Oktober 2023 07:30:50 MESZ schrieb AKASHI Takahiro <takahiro.aka...@linaro.org>: >Now it is clear that the feature actually depends on efi interfaces, >not "bootefi" command. efi_set_bootdev() will automatically be nullified >if necessary efi component is disabled. > >Signed-off-by: AKASHI Takahiro <takahiro.aka...@linaro.org> >--- > fs/fs.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > >diff --git a/fs/fs.c b/fs/fs.c >index 4cb4310c9cc2..70cdb594c4c8 100644 >--- a/fs/fs.c >+++ b/fs/fs.c >@@ -791,10 +791,9 @@ int do_load(struct cmd_tbl *cmdtp, int flag, int argc, >char *const argv[], > return 1; > } > >- if (IS_ENABLED(CONFIG_CMD_BOOTEFI)) >- efi_set_bootdev(argv[1], (argc > 2) ? argv[2] : "", >- (argc > 4) ? argv[4] : "", map_sysmem(addr, 0), >- len_read); >+ efi_set_bootdev(argv[1], (argc > 2) ? argv[2] : "", This function should not exist for CONFIG_EFI_LOADER=n. There are other places where the function is invoked. Please, review all of them. Best regards Heinrich >+ (argc > 4) ? argv[4] : "", map_sysmem(addr, 0), >+ len_read); > > printf("%llu bytes read in %lu ms", len_read, time); > if (time > 0) {
- Re: [RFC 02/13] cmd: bootefi: re-organize do_... AKASHI Takahiro
- [RFC 03/13] cmd: bootefi: carve out EFI boot manager i... AKASHI Takahiro
- [RFC 04/13] cmd: bootefi: carve out binary execution i... AKASHI Takahiro
- [RFC 06/13] cmd: efidebug: ease efi configuration depe... AKASHI Takahiro
- [RFC 07/13] bootmeth: use efi_loader interfaces instea... AKASHI Takahiro
- [RFC 05/13] cmd: bootefi: move library interfaces unde... AKASHI Takahiro
- [RFC 08/13] efi_loader: split unrelated code from efi_... AKASHI Takahiro
- [RFC 09/13] efi_loader: rename BOOTEFI_BOOTMGR to EFI_... AKASHI Takahiro
- [RFC 10/13] net: tftp: remove explicit efi configurati... AKASHI Takahiro
- [RFC 11/13] fs: remove explicit efi configuration depe... AKASHI Takahiro
- Re: [RFC 11/13] fs: remove explicit efi configura... Heinrich Schuchardt
- Re: [RFC 11/13] fs: remove explicit efi confi... AKASHI Takahiro
- Re: [RFC 11/13] fs: remove explicit efi c... Tom Rini
- Re: [RFC 11/13] fs: remove explicit e... AKASHI Takahiro
- Re: [RFC 11/13] fs: remove expli... Tom Rini
- [RFC 12/13] lib: uuid: move CONFIG_RANDOM_UUID AKASHI Takahiro
- Re: [RFC 12/13] lib: uuid: move CONFIG_RANDOM_UUI... Tom Rini
- Re: [RFC 12/13] lib: uuid: move CONFIG_RANDOM_UUI... Ilias Apalodimas
- [RFC 13/13] block: rkmtd: select CONFIG_RANDOM_UUID ex... AKASHI Takahiro
- Re: [RFC 00/13] cmd: bootefi: refactor the code for bo... Tom Rini