Simon, I've reviewed patch#2 which I had some concerns and it looks ok. The series is assigned to me but you've reviewed the vast majority of the patchset. Will you send ti via the -dm tree or shall I pick it up?
Thanks /Ilias On Tue, Sep 12, 2023 at 02:34:59PM -0700, seanedm...@linux.microsoft.com wrote: > From: Sean Edmond <seanedm...@microsoft.com> > > This patch series creates a common API (fdt_fixup_kaslr_seed()) for > populating the kaslr seed in the DTB. Existing users (kaslrseed, > and ARMv8 sec firmware) have been updated to use this common API. > > New functionality has been introduced to populate the kaslr using > the RNG. This can be enabled with CONFIG_RNG_TPM_SEED. > > changes in v3: > - Populate with RNG device instead of TPM device (this is a more generic > solution) > - Use event spy to do the FDT fixup > - fix compile error for sandbox for !OFNODE_MULTI_TREE > > changes in v2: > - fdt_fixup_kaslr_seed() uses the ofnode API > - Add root_ofnode_from_fdt() to get the root node from an FDT and > perform error checking on the oftree > - add comments to exported functions > - Add error checking in image_setup_libfdt() for return from > fdt_tpm_kaslr_seed() > - uclass_get_device() -> uclass_first_device_err() > - Change default config for OFNODE_MULTI_TREE (y if !OF_LIVE) > > > Dhananjay Phadke (2): > fdt: common API to populate kaslr seed > fdt: kaslr seed from RNG device > > Sean Edmond (3): > cmd: kaslrseed: Use common API to fixup FDT > dm: core: Modify default for OFNODE_MULTI_TREE > fdt: Fix compile error for !OFNODE_MULTI_TREE > > arch/arm/cpu/armv8/sec_firmware.c | 39 ++++++++-------------- > cmd/kaslrseed.c | 22 +++++-------- > common/fdt_support.c | 55 +++++++++++++++++++++++++++++++ > drivers/core/Kconfig | 2 +- > drivers/core/ofnode.c | 29 ++++++++++++---- > include/dm/ofnode.h | 12 +++++++ > include/fdt_support.h | 9 +++++ > lib/Kconfig | 7 ++++ > 8 files changed, 129 insertions(+), 46 deletions(-) > > -- > 2.40.0 >