Re: [PATCH v2 5/8] usb: xhci: Fail on attempt to queue TRBs to a halted endpoint

[Marek Vasut]

On 10/29/23 07:37, Hector Martin wrote:

This isn't going to work, don't pretend it will and then end up timing
out.

Signed-off-by: Hector Martin <mar...@marcan.st>
---
  drivers/usb/host/xhci-ring.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index db8b8f200250..a969eafdc8ee 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -243,7 +243,8 @@ static int prepare_ring(struct xhci_ctrl *ctrl, struct 
xhci_ring *ep_ring,
                puts("WARN waiting for error on ep to be cleared\n");
                return -EINVAL;
        case EP_STATE_HALTED:
-               puts("WARN halted endpoint, queueing URB anyway.\n");
+               puts("WARN endpoint is halted\n");
+               return -EINVAL;

Reviewed-by: Marek Vasut <ma...@denx.de>