Dear Michael Trimarchi,
> This patch add the watchdog reset function to the atmel atsam9x architectures.

NAK.

Watchdog already exists at drivers/watchdog/at91sam9_wdt.c :)

Maybe its a bit of an obscure location... But it is already invented ;)

> +     int re_enable = disable_interrupts();
> +
> +     writel(AT91_WDT_CR_WDRSTT | AT91_WDT_CR_KEY, &wdt->cr);
> +
> +     if (re_enable)
> +             enable_interrupts();

Besides... why would we need to disable IRQs here, writel() is using one 
instruction
to write to the address?

Best Regards,

Reinhard
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to