вт, 31 жовт. 2023 р. о 10:57 Jaehoon Chung <jh80.ch...@samsung.com> пише:
>
>
>
> > -----Original Message-----
> > From: Svyatoslav Ryhel <clamo...@gmail.com>
> > Sent: Friday, October 27, 2023 5:26 PM
> > To: Tom Rini <tr...@konsulko.com>; Jaehoon Chung <jh80.ch...@samsung.com>;
> > Simon Glass
> > <s...@chromium.org>; Svyatoslav Ryhel <clamo...@gmail.com>
> > Cc: u-boot@lists.denx.de
> > Subject: [PATCH v9 3/8] power: pmic: add the base MAX77663 PMIC support
> >
> > Add support to bind the regulators/child nodes with the pmic.
> > Also adds the pmic i2c based read/write functions to access pmic
> > registers.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamo...@gmail.com>
> > Reviewed-by: Simon Glass <s...@chromium.org>
>
> Reviewed-by: Jaehoon Chung <jh80.ch...@samsung.com>
>
> Just add a minor comment at below.
>
> > ---
> > doc/device-tree-bindings/pmic/max77663.txt | 84 ++++++++++++++++++++++
> > drivers/power/pmic/Kconfig | 9 +++
> > drivers/power/pmic/Makefile | 1 +
> > drivers/power/pmic/max77663.c | 81 +++++++++++++++++++++
> > include/power/max77663.h | 42 +++++++++++
> > 5 files changed, 217 insertions(+)
> > create mode 100644 doc/device-tree-bindings/pmic/max77663.txt
> > create mode 100644 drivers/power/pmic/max77663.c
> > create mode 100644 include/power/max77663.h
> >
> > diff --git a/doc/device-tree-bindings/pmic/max77663.txt
> > b/doc/device-tree-bindings/pmic/max77663.txt
> > new file mode 100644
> > index 0000000000..ddb7d3eb14
> > --- /dev/null
> > +++ b/doc/device-tree-bindings/pmic/max77663.txt
> > @@ -0,0 +1,84 @@
> > +MAXIM, MAX77663 PMIC
> > +
> > +This device uses two drivers:
> > +- drivers/power/pmic/max77663.c (for parent device)
> > +- drivers/power/regulator/max77663_regulator.c (for child regulators)
> > +
> > +This chapter describes the binding info for the PMIC driver and regulators.
> > +
> > +Required properties for PMIC:
> > +- compatible: "maxim,max77663"
> > +- reg: usually 0x1c or 0x3c
> > +
> > +With those two properties, the pmic device can be used for read/write only.
> > +To bind each regulator, the optional regulators subnode should exists.
> > +
> > +Optional subnode:
> > +- name: regulators (subnode list of each device's regulator)
> > +
> > +Regulators subnode contains set on supported regulators.
> > +
> > +Required properties:
> > +- regulator-name: used for regulator uclass platform data '.name',
> > +
> > +List of supported regulator nodes names for max77663:
> > +- sd0, sd1, sd2, sd3, ldo0, ldo1, ldo2, ldo3, ldo4, ldo5, ldo6, ldo7, ldo8
> > +
> > +Optional:
> > +- regulator-min-microvolt: minimum allowed Voltage to set
> > +- regulator-max-microvolt: minimum allowed Voltage to set
> > +- regulator-always-on: regulator should be never disabled
> > +- regulator-boot-on: regulator should be enabled by the bootloader
> > +
> > +Linux driver binding for this driver is compatible.
> > +
> > +Example:
> > +
> > +max77663@1c {
> > + compatible = "maxim,max77663";
> > + reg = <0x1c>;
> > +
> > + regulators {
> > + sd0 {
> > + regulator-name = "vdd_cpu";
> > + regulator-min-microvolt = <800000>;
> > + regulator-max-microvolt = <1250000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + ...
> > +
> > + ldo0 {
> > + regulator-name = "avdd_pll";
> > + regulator-min-microvolt = <1200000>;
> > + regulator-max-microvolt = <1200000>;
> > + };
> > +
> > + ...
> > +
> > + ldo2 {
> > + regulator-name = "avdd_usb";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + ldo3 {
> > + regulator-name = "vdd_sdmmc3";
> > + regulator-min-microvolt = <3000000>;
> > + regulator-max-microvolt = <3000000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + ...
> > +
> > + ldo8 {
> > + regulator-name = "avdd_dsi_csi";
> > + regulator-min-microvolt = <1200000>;
> > + regulator-max-microvolt = <1200000>;
> > + };
> > + };
> > +};
> > diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig
> > index 4a6f0ce093..54665d7e2b 100644
> > --- a/drivers/power/pmic/Kconfig
> > +++ b/drivers/power/pmic/Kconfig
> > @@ -184,6 +184,15 @@ config SPL_DM_PMIC_PFUZE100
> > This config enables implementation of driver-model pmic uclass
> > features
> > for PMIC PFUZE100 in SPL. The driver implements read/write operations.
> >
> > +config DM_PMIC_MAX77663
> > + bool "Enable Driver Model for PMIC MAX77663"
> > + ---help---
> > + This config enables implementation of driver-model pmic uclass
> > features
> > + for PMIC MAX77663. The driver implements read/write operations.
> > + This is a Power Management IC with a decent set of peripherals from
> > which
> > + 4 DC-to-DC Step-Down (SD) Regulators, 9 Low-Dropout Linear (LDO)
> > Regulators,
> > + 8 GPIOs, Real-Time Clock (RTC) and more with I2C Compatible Interface.
> > +
> > config DM_PMIC_MAX77686
> > bool "Enable Driver Model for PMIC MAX77686"
> > ---help---
> > diff --git a/drivers/power/pmic/Makefile b/drivers/power/pmic/Makefile
> > index 0b3b3d62d0..414a9d8225 100644
> > --- a/drivers/power/pmic/Makefile
> > +++ b/drivers/power/pmic/Makefile
> > @@ -6,6 +6,7 @@
> > obj-$(CONFIG_$(SPL_TPL_)DM_PMIC) += pmic-uclass.o
> > obj-$(CONFIG_$(SPL_)DM_PMIC_FAN53555) += fan53555.o
> > obj-$(CONFIG_$(SPL_)DM_PMIC_DA9063) += da9063.o
> > +obj-$(CONFIG_$(SPL_)DM_PMIC_MAX77663) += max77663.o
> > obj-$(CONFIG_DM_PMIC_MAX77686) += max77686.o
> > obj-$(CONFIG_DM_PMIC_MAX8998) += max8998.o
> > obj-$(CONFIG_DM_PMIC_MC34708) += mc34708.o
> > diff --git a/drivers/power/pmic/max77663.c b/drivers/power/pmic/max77663.c
> > new file mode 100644
> > index 0000000000..fac97ed221
> > --- /dev/null
> > +++ b/drivers/power/pmic/max77663.c
> > @@ -0,0 +1,81 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright(C) 2023 Svyatoslav Ryhel <clamo...@gmail.com>
> > + */
> > +
> > +#include <dm.h>
> > +#include <dm/lists.h>
> > +#include <power/pmic.h>
> > +#include <power/max77663.h>
> > +
> > +static const struct pmic_child_info pmic_children_info[] = {
> > + { .prefix = "ldo", .driver = MAX77663_LDO_DRIVER },
> > + { .prefix = "sd", .driver = MAX77663_SD_DRIVER },
> > + { },
> > +};
> > +
> > +static int max77663_write(struct udevice *dev, uint reg, const uint8_t
> > *buff,
> > + int len)
> > +{
> > + int ret;
> > +
> > + ret = dm_i2c_write(dev, reg, buff, len);
> > + if (ret) {
> > + log_debug("write error to device: %p register: %#x!\n", dev,
> > reg);
> > + return ret;
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static int max77663_read(struct udevice *dev, uint reg, uint8_t *buff, int
> > len)
> > +{
> > + int ret;
> > +
> > + ret = dm_i2c_read(dev, reg, buff, len);
> > + if (ret) {
> > + log_debug("read error from device: %p register: %#x!\n", dev,
> > reg);
> > + return ret;
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static int max77663_bind(struct udevice *dev)
> > +{
> > + ofnode regulators_node;
> > + int children;
> > +
> > + regulators_node = dev_read_subnode(dev, "regulators");
> > + if (!ofnode_valid(regulators_node)) {
> > + log_err("%s regulators subnode not found!\n", dev->name);
> > + return -ENXIO;
> > + }
> > +
> > + debug("%s: '%s' - found regulators subnode\n", __func__, dev->name);
> > +
> > + children = pmic_bind_children(dev, regulators_node,
> > pmic_children_info);
> > + if (!children)
> > + log_err("%s - no child found\n", dev->name);
> > +
> > + /* Always return success for this device */
> > + return 0;
> > +}
> > +
> > +static struct dm_pmic_ops max77663_ops = {
> > + .read = max77663_read,
> > + .write = max77663_write,
> > +};
> > +
> > +static const struct udevice_id max77663_ids[] = {
> > + { .compatible = "maxim,max77663" },
> > + { }
> > +};
> > +
> > +U_BOOT_DRIVER(pmic_max77663) = {
> > + .name = "max77663_pmic",
> > + .id = UCLASS_PMIC,
> > + .of_match = max77663_ids,
> > + .bind = max77663_bind,
> > + .ops = &max77663_ops,
> > +};
> > diff --git a/include/power/max77663.h b/include/power/max77663.h
> > new file mode 100644
> > index 0000000000..0f764bcbcc
> > --- /dev/null
> > +++ b/include/power/max77663.h
> > @@ -0,0 +1,42 @@
> > +/* SPDX-License-Identifier: GPL-2.0+ */
> > +/*
> > + * Copyright(C) 2023 Svyatoslav Ryhel <clamo...@gmail.com>
> > + */
> > +
> > +#ifndef _MAX77663_H_
> > +#define _MAX77663_H_
> > +
> > +#define MAX77663_LDO_NUM 9
> > +#define MAX77663_SD_NUM 5
> > +
> > +/* Drivers name */
> > +#define MAX77663_LDO_DRIVER "max77663_ldo"
> > +#define MAX77663_SD_DRIVER "max77663_sd"
> > +
> > +/* Step-Down (SD) Regulator calculations */
> > +#define SD_STATUS_MASK 0x30
> > +
> > +#define SD0_VOLT_MAX_HEX 0x40
> > +#define SD1_VOLT_MAX_HEX 0x4c
> > +#define SD_VOLT_MAX_HEX 0xff
> > +#define SD_VOLT_MIN_HEX 0x02
> > +
> > +#define SD0_VOLT_MAX 1400000
> > +#define SD1_VOLT_MAX 1550000
> > +#define SD_VOLT_MAX 3787500
> > +#define SD_VOLT_MIN 625000
> > +
> > +#define SD_VOLT_BASE 600000
> > +
> > +/* Low-Dropout Linear (LDO) Regulator calculations */
> > +#define LDO_STATUS_MASK 0xc0
> > +#define LDO_VOLT_MASK 0x3f
> > +#define LDO_VOLT_MAX_HEX 0x3f
> > +
> > +#define LDO01_VOLT_MAX 2375000
>
> Does it mean ldo0~1 or only ldo1?
>
0 and 1, then 4 and then the rest. They are grouped by common the
properties (max voltage and step)
Best regards,
Svyatoslav R.
> > +#define LDO4_VOLT_MAX 1587500
> > +#define LDO_VOLT_MAX 3950000
> > +
> > +#define LDO_VOLT_BASE 800000
> > +
> > +#endif /* _MAX77663_H_ */
> > --
> > 2.39.2
>
>
