On Fri, Oct 20, 2023 at 01:42:53PM -0500, Sam Protsenko wrote: > The global SYS_CONFIG_NAME in axy17lte Kconfig overrides SYS_CONFIG_NAME > for all boards specified after this line in > arch/arm/mach-exynos/Kconfig: > > source "board/samsung/axy17lte/Kconfig" > > Right now it's the last 'source' line there, so the issue is not > reproducible. But once some board is moved or added after this line the > next build error will happen:
Good spotting on this one. [snip] > diff --git a/board/samsung/axy17lte/Kconfig b/board/samsung/axy17lte/Kconfig > index a018547ff5d4..209394a8a5a8 100644 > --- a/board/samsung/axy17lte/Kconfig > +++ b/board/samsung/axy17lte/Kconfig > @@ -1,11 +1,3 @@ > -config SYS_CONFIG_NAME > - string "Board configuration name" > - default "exynos78x0-common.h" > - help > - This option contains information about board configuration name. > - Based on this option include/configs/<CONFIG_SYS_CONFIG_NAME>.h header > - will be used for board configuration. > - > if TARGET_A5Y17LTE > config SYS_BOARD > default "axy17lte" But this isn't right as Minkyu points out because SYS_CONFIG_NAME isn't set for these platforms now. The fix is to do as board/freescale/lx2160a/Kconfig does for example and have SYS_CONFIG_NAME under each if TARGET_... stanza, even if we're repeating the value. It may or may not look cleaner to do: config SYS_CONFIG_NAME default "exynos78x0-common.h" if TARGET_A5Y17LTE || \ TARGET_A7Y17LTE || TARGET_A3Y17LTE In the file directly, instead. -- Tom
signature.asc
Description: PGP signature