In this test, "scmi" command is tested against different sub-commands.
Please note that scmi command is for debug purpose and is not intended
in production system.

Signed-off-by: AKASHI Takahiro <takahiro.aka...@linaro.org>
Reviewed-by: Simon Glass <s...@chromium.org>
Reviewed-by: Etienne Carriere <etienne.carri...@foss.st.com>
---
v7
* make test assertions more flexible depending on the number of provided
  protocols
v4
* move 'base'-related changes to the prior commit
* add CONFIG_CMD_SCMI to sandbox_defconfig
v3
* change char to u8 in vendor/agent names
v2
* use helper functions, removing direct uses of ops
---
 configs/sandbox_defconfig |  1 +
 test/dm/scmi.c            | 81 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 82 insertions(+)

diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
index bc5bcb2a6237..c550af93b0ca 100644
--- a/configs/sandbox_defconfig
+++ b/configs/sandbox_defconfig
@@ -121,6 +121,7 @@ CONFIG_CMD_REGULATOR=y
 CONFIG_CMD_AES=y
 CONFIG_CMD_TPM=y
 CONFIG_CMD_TPM_TEST=y
+CONFIG_CMD_SCMI=y
 CONFIG_CMD_BTRFS=y
 CONFIG_CMD_CBFS=y
 CONFIG_CMD_CRAMFS=y
diff --git a/test/dm/scmi.c b/test/dm/scmi.c
index 2f63f2da16fb..2bcf7ac6fcc3 100644
--- a/test/dm/scmi.c
+++ b/test/dm/scmi.c
@@ -19,6 +19,7 @@
 #include <scmi_agent.h>
 #include <scmi_agent-uclass.h>
 #include <scmi_protocols.h>
+#include <vsprintf.h>
 #include <asm/scmi_test.h>
 #include <dm/device-internal.h>
 #include <dm/test.h>
@@ -206,6 +207,86 @@ static int dm_test_scmi_base(struct unit_test_state *uts)
 
 DM_TEST(dm_test_scmi_base, UT_TESTF_SCAN_FDT);
 
+static int dm_test_scmi_cmd(struct unit_test_state *uts)
+{
+       struct udevice *agent_dev;
+       int num_proto = 0;
+       char cmd_out[30];
+
+       if (!IS_ENABLED(CONFIG_CMD_SCMI))
+               return 0;
+
+       /* preparation */
+       ut_assertok(uclass_get_device_by_name(UCLASS_SCMI_AGENT, "scmi",
+                                             &agent_dev));
+       ut_assertnonnull(agent_dev);
+
+       /*
+        * Estimate the number of provided protocols.
+        * This estimation is correct as far as a corresponding
+        * protocol support is added to sandbox fake serer.
+        */
+       if (IS_ENABLED(CONFIG_SCMI_POWER_DOMAIN))
+               num_proto++;
+       if (IS_ENABLED(CONFIG_CLK_SCMI))
+               num_proto++;
+       if (IS_ENABLED(CONFIG_RESET_SCMI))
+               num_proto++;
+       if (IS_ENABLED(CONFIG_DM_REGULATOR_SCMI))
+               num_proto++;
+
+       /* scmi info */
+       ut_assertok(run_command("scmi info", 0));
+
+       ut_assert_nextline("SCMI device: scmi");
+       snprintf(cmd_out, 30, "  protocol version: 0x%x",
+                SCMI_BASE_PROTOCOL_VERSION);
+       ut_assert_nextline(cmd_out);
+       ut_assert_nextline("  # of agents: 2");
+       ut_assert_nextline("      0: platform");
+       ut_assert_nextline("    > 1: OSPM");
+       snprintf(cmd_out, 30, "  # of protocols: %d", num_proto);
+       ut_assert_nextline(cmd_out);
+       if (IS_ENABLED(CONFIG_SCMI_POWER_DOMAIN))
+               ut_assert_nextline("      Power domain management");
+       if (IS_ENABLED(CONFIG_CLK_SCMI))
+               ut_assert_nextline("      Clock management");
+       if (IS_ENABLED(CONFIG_RESET_SCMI))
+               ut_assert_nextline("      Reset domain management");
+       if (IS_ENABLED(CONFIG_DM_REGULATOR_SCMI))
+               ut_assert_nextline("      Voltage domain management");
+       ut_assert_nextline("  vendor: U-Boot");
+       ut_assert_nextline("  sub vendor: Sandbox");
+       ut_assert_nextline("  impl version: 0x1");
+
+       ut_assert_console_end();
+
+       /* scmi perm_dev */
+       ut_assertok(run_command("scmi perm_dev 1 0 1", 0));
+       ut_assert_console_end();
+
+       ut_assert(run_command("scmi perm_dev 1 0 0", 0));
+       ut_assert_nextline("Denying access to device:0 failed (-13)");
+       ut_assert_console_end();
+
+       /* scmi perm_proto */
+       ut_assertok(run_command("scmi perm_proto 1 0 14 1", 0));
+       ut_assert_console_end();
+
+       ut_assert(run_command("scmi perm_proto 1 0 14 0", 0));
+       ut_assert_nextline("Denying access to protocol:0x14 on device:0 failed 
(-13)");
+       ut_assert_console_end();
+
+       /* scmi reset */
+       ut_assert(run_command("scmi reset 1 1", 0));
+       ut_assert_nextline("Reset failed (-13)");
+       ut_assert_console_end();
+
+       return 0;
+}
+
+DM_TEST(dm_test_scmi_cmd, UT_TESTF_SCAN_FDT);
+
 static int dm_test_scmi_power_domains(struct unit_test_state *uts)
 {
        struct sandbox_scmi_agent *agent;
-- 
2.34.1

Reply via email to