On Mon, Nov 27, 2023 at 06:56:47PM +0600, Maxim Uvarov wrote: > U-Boot recently got support for an alternative network stack using LWIP. > Replace dns command with the LWIP variant while keeping the output and > error messages identical. > > Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> [snip] > diff --git a/net/lwip/Makefile b/net/lwip/Makefile > index 3fd5d34564..5d8d5527c6 100644 > --- a/net/lwip/Makefile > +++ b/net/lwip/Makefile > @@ -62,3 +62,5 @@ obj-$(CONFIG_NET) += lwip-external/src/netif/ethernet.o > > obj-$(CONFIG_NET) += port/if.o > obj-$(CONFIG_NET) += port/sys-arch.o > + > +obj-y += apps/dns/lwip-dns.o
Shouldn't this depend on CONFIG symbol? There's CONFIG_CMD_DNS today. And I'll assume this is maybe an issue with other parts of the series, so please check and confirm those as well. > diff --git a/net/lwip/apps/dns/lwip-dns.c b/net/lwip/apps/dns/lwip-dns.c > new file mode 100644 > index 0000000000..3ee6e24ef4 > --- /dev/null > +++ b/net/lwip/apps/dns/lwip-dns.c > @@ -0,0 +1,63 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +/* > + * (C) Copyright 2023 Linaro Ltd. <maxim.uva...@linaro.org> > + */ > + > +#include <common.h> Here and elsewhere, no common.h usage, please include what you need from it directly. -- Tom
signature.asc
Description: PGP signature