Hi Antoine, On 05/12/23 21:25, Devarsh Thakkar wrote: > Move video memory reservation for SPL at end of RAM so that it does > not interefere with reservations for next stage so that the next stage > need not have holes in between for passed regions and instead it can > maintain continuity in reservations. > > Also catch the bloblist before starting reservations to avoid the same > problem. > > While at it, also fill missing fields in video handoff struct before > passing it to next stage. > > This is as per discussions at : > For moving SPL framebuffer reservation at end of RAM: > > https://lore.kernel.org/all/capnjgz3xsoe_g3yrqwuavoivjufz+yqgkor0ztvxgt9vk8t...@mail.gmail.com/ > > For filling missing video handoff fields : > https://lore.kernel.org/all/CAPnjgZ1Hs0rNf0JDirp6YPsOQ5=qqqsp9g9qrwlooasuv8a...@mail.gmail.com/ > > Changelog: > V2: > - Make a generic function to reserve video memory at SPL stage. > - Add debug prints while skipping framebuffer allocation at uboot. > - Correct commenting style as suggested. > > V3: > - Change spl_reserve_video to spl_reserve_video_from_ram_top > which enforce framebuffer reservation from end of RAM. > - Use gd->ram_top instead of local ram_top and update > gd->reloc_addr after each reservation. > - Print error message on framebuffer reservation. > - Update SPL doc with spl splash screen specific info. > > V4: > - Split patches into atomic commits. > - Remove duplicate check for video blob passed addresses and error out > if invalid address/size received from blob. > - Improve SPL documentation memory reservation scheme and print message > for video memory reservation from bloblist. > - Add Reviewed-By. > > V5: > - Add comment for filling video handoff size with aligned size > - Use PHASE_BOARD_F while checking for U-boot proper stage > - Add Reviewed-by >
Is it possible to pull this series in if no further comments ? Regards Devarsh > Test logs: > https://gist.github.com/devarsht/30a3c1591270c9ebae00714b48d33058 > > Devarsh Thakkar (8): > spl: Enforce framebuffer reservation from end of RAM > arm: mach-k3: common: Reserve video memory from end of the RAM > board: ti: am62x: evm: Remove video_setup from spl_board_init > common/board_f: Catch bloblist before starting reservations > video: Skip framebuffer reservation if already reserved > video: Fill video handoff in video post probe > doc: spl: Add info for missing Kconfigs > doc: spl: Add info regarding memory reservation > > arch/arm/mach-k3/common.c | 17 ++++++++++----- > board/ti/am62x/evm.c | 18 ---------------- > common/board_f.c | 41 +++++++++++++++++++++++++++++++----- > common/spl/spl.c | 19 +++++++++++++++++ > doc/develop/spl.rst | 37 ++++++++++++++++++++++++++++++++ > drivers/video/video-uclass.c | 40 ++++++++++++++++++++++++----------- > include/spl.h | 10 +++++++++ > 7 files changed, 142 insertions(+), 40 deletions(-) >
