On Thu, Dec 14, 2023 at 09:50:19AM -0700, Simon Glass wrote: > Add fields for the three bootm parameters and other things needed for > booting. Also add a helper to set up the struct correctly. > > Signed-off-by: Simon Glass <s...@chromium.org> [snip] > diff --git a/include/bootm.h b/include/bootm.h > index 85c560d5a0ae..c9ab55f18d39 100644 > --- a/include/bootm.h > +++ b/include/bootm.h > @@ -19,17 +19,52 @@ struct cmd_tbl; > /** > * struct bootm_info() - information used when processing images to boot > * > + * These mirror the first three arguments of the bootm command. They are > + * designed to handle any type of image, but typically it is a FIT. > + * > + * @addr_fit: Address of image to bootm, as passed to
Maybe we should just call this addr_img ? I was fine with this at first, and then started reviewing 14+ and it just reads oddly at that point. Since we use this for starting everything in memory I think we should name this a bit more generically, and avoid the editorializing about being typically FIT as well. -- Tom
signature.asc
Description: PGP signature
