From: Jagan Teki <ja...@edgeble.ai>

Get the regs from priv pointer instead of passing it an argument.

This would simplify the code and better readability.

Signed-off-by: Jagan Teki <ja...@edgeble.ai>
---
Changes for v2:
- none

 drivers/video/rockchip/rk_vop.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/video/rockchip/rk_vop.c b/drivers/video/rockchip/rk_vop.c
index c514e2a0e4..158ba7cbf6 100644
--- a/drivers/video/rockchip/rk_vop.c
+++ b/drivers/video/rockchip/rk_vop.c
@@ -39,11 +39,13 @@ enum vop_pol {
        DCLK_INVERT    = 3
 };
 
-static void rkvop_enable(struct udevice *dev, struct rk3288_vop *regs, ulong 
fbbase,
+static void rkvop_enable(struct udevice *dev, ulong fbbase,
                         int fb_bits_per_pixel,
                         const struct display_timing *edid,
                         struct reset_ctl *dclk_rst)
 {
+       struct rk_vop_priv *priv = dev_get_priv(dev);
+       struct rk3288_vop *regs = priv->regs;
        u32 lb_mode;
        u32 rgb_mode;
        u32 hactive = edid->hactive.typ;
@@ -243,9 +245,7 @@ static void rkvop_mode_set(struct udevice *dev,
 static int rk_display_init(struct udevice *dev, ulong fbbase, ofnode ep_node)
 {
        struct video_priv *uc_priv = dev_get_uclass_priv(dev);
-       struct rk_vop_priv *priv = dev_get_priv(dev);
        int vop_id, remote_vop_id;
-       struct rk3288_vop *regs = priv->regs;
        struct display_timing timing;
        struct udevice *disp;
        int ret;
@@ -380,7 +380,7 @@ static int rk_display_init(struct udevice *dev, ulong 
fbbase, ofnode ep_node)
                return ret;
        }
 
-       rkvop_enable(dev, regs, fbbase, 1 << l2bpp, &timing, &dclk_rst);
+       rkvop_enable(dev, fbbase, 1 << l2bpp, &timing, &dclk_rst);
 
        ret = display_enable(disp, 1 << l2bpp, &timing);
        if (ret)
-- 
2.25.1

Reply via email to