On Tue, Mar 29, 2011 at 1:40 AM, Prafulla Wadaskar wrote: > From: Lei Wen [mailto:lei...@marvell.com] >> +#define orb(v, c) writeb(readb(c) | (v), c) > > If I am not wrong, this should be like > #define orb(v, c) writeb((readb(c) | v), c)
no, Lei's version is correct. yours mishandles v, and adds useless paren to the first arg to writeb. writeb itself should be wrapping its first arg in paren if need be. -mike _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
