Hi Prafulla, On Thu, Mar 31, 2011 at 2:56 AM, Prafulla Wadaskar <prafu...@marvell.com> wrote: > > >> -----Original Message----- >> From: Lei Wen [mailto:adrian.w...@gmail.com] >> Sent: Wednesday, March 30, 2011 7:36 PM >> To: Prafulla Wadaskar >> Cc: Lei Wen; Heiko Schocher; Wolfgang Denk; u-boot@lists.denx.de; Marek >> Vasut; Ashish Karkare; Prabhanjan Sarnaik; Yu Tang >> Subject: Re: [PATCH V5 4/6] I2C: add i2c support for Pantheon platform >> >> Hi Prafulla, >> >> On Tue, Mar 29, 2011 at 9:07 PM, Prafulla Wadaskar >> <prafu...@marvell.com> wrote: >> > >> > >> >> -----Original Message----- >> >> From: Lei Wen [mailto:lei...@marvell.com] >> >> Sent: Monday, March 28, 2011 12:24 PM >> >> To: Heiko Schocher; Prafulla Wadaskar; Wolfgang Denk; u- >> >> b...@lists.denx.de; Marek Vasut; Ashish Karkare; Prabhanjan Sarnaik; >> Yu >> >> Tang; adrian.w...@gmail.com >> >> Subject: [PATCH V5 4/6] I2C: add i2c support for Pantheon platform >> >> >> >> Add i2c support to dkb board with pantheon soc. >> >> >> >> Signed-off-by: Lei Wen <lei...@marvell.com> >> >> --- >> >> Changelog: >> >> V2: >> >> NO CHANGE >> >> >> >> V3: >> >> clean code sytle issue >> >> Add i2c clock enable code include in I2C configure define block >> >> >> >> V4: >> >> make i2c definition included in the ifdef >> >> >> >> V5: >> >> NO CHANGE >> >> >> >> arch/arm/cpu/arm926ejs/pantheon/cpu.c | 12 ++++++++++++ >> >> arch/arm/include/asm/arch-pantheon/cpu.h | 4 +++- >> >> arch/arm/include/asm/arch-pantheon/mfp.h | 6 ++++-- >> >> board/Marvell/dkb/dkb.c | 4 ++++ >> >> include/configs/dkb.h | 13 +++++++++++++ >> >> 5 files changed, 36 insertions(+), 3 deletions(-) >> >> >> > ...snip... >> > >> >> diff --git a/include/configs/dkb.h b/include/configs/dkb.h >> >> index 638af5e..599c8b8 100644 >> >> --- a/include/configs/dkb.h >> >> +++ b/include/configs/dkb.h >> >> @@ -56,6 +56,19 @@ >> >> #include "mv-common.h" >> >> >> >> #undef CONFIG_ARCH_MISC_INIT >> >> + >> >> +/* >> >> + * I2C definition >> >> + */ >> >> +#define CONFIG_CMD_I2C >> > >> > This command definition should be moved up (below #include >> <config_cmd_default.h> >> >> I'm ok to put this define to the config_cmd_default.h, but this mean >> many other platform need >> which didn't not need the i2c but include the <config_cmd_default.h>, >> need to undef the i2c now. >> Does that worth the change? > > I don't mean here to put it in to the config_cmd_default.h > I means put it below #include <config_cmd_default.h> line where other > commands are defined/undefed. >
Understand... Patch to come... Best regards, Lei _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot