From: Anthony Loiseau <anthony.lois...@allcircuits.com>
Please find a patch proposal which slightly modifies get_maintainer.pl
penguin_chief list.
This proposal aims to workaround get_maintainer.pl behavior for ARM, ARM_TI
and THE_REST sections (see MAINTAINERS file) for which Tom Rini was not
outputed as a maintainer by get_maintainer.pl.
Root issue is that get_maintainer.pl threats penguin_chiefs this way:
- with --git-chief-penguins, penguin_chiefs are appended to all results
- with --no-git-chief-penguins (the default), penguin chiefs are stripped
out of all results
That is, since Tom Rini is set as a penguin chief inside get_maintainer.pl,
get_maintainer.pl never outputs him as a maintainer with usual uses.
This issue does not hurt that much for upstream Linux code since Linus Torvalds
is not listed in MAINTAINERS file except for THE_REST, but sections coverage is
good so "THE REST" section almost never triggers.
I saw several options to fix this:
- OPT1: get in touch with Linux upstream to change --no-git-chief-penguins
behavior so it does nothing instead of stripping chiefs from results
- OPT2: take advantage of case-sensitive (name, email) comparison
to keep Tom Rini chief as Tom RINI.
- OPT3: clear penguin_chiefs, breaking --git-chief-penguins
- OPT4: implement OPT1 here
>From an email discussion on LKML [1] my understanding is that upstream votes
for downstream edits here, hence this patch proposal for OPT2.
Note of interest: this fixes "THE REST" catch all sectioni too, resulting
in Tom Rini listed as (maintainer:THE REST) for all repo files.
If you think developers automatically fills patch emails to/cc from
get_maintainer.pl output, then you may want to break it again by setting its
maintainer as Tom RINI.
[1]
https://lore.kernel.org/lkml/13fd63b7e8e0f197842ae1f1264e50c9614d0667.ca...@perches.com/T/
Regards,
Anthony
Cc: Tom Rini <tr...@konsulko.com>
Anthony Loiseau (1):
get_maintainer.pl: slightly modify penguin_chief
scripts/get_maintainer.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.11.0
