Hi Dragan,
On 2/1/24 05:02, Dragan Simic wrote:
[Some people who received this message don't often get email from
dsi...@manjaro.org. Learn why this is important at
https://aka.ms/LearnAboutSenderIdentification ]
Hello Kever and Quentin,
On 2024-02-01 03:48, Kever Yang wrote:
On 2024/1/23 22:49, Quentin Schulz wrote:
From: Quentin Schulz <quentin.sch...@theobroma-systems.com>
Compared to the original misc_init_r from Rockchip mach code,
setup_iodomain() is added and rockchip_setup_macaddr() is not called.
It is assumed adding rockchip_setup_macaddr() back is fine.
Let's use rockchip_early_misc_init_r instead of reimplementing the
whole
misc_init_r from Rockchip (the side effect being that
rockchip_setup_macaddr() is back).
We might actually introduce some issues with this change. I'll get
back later with a more detailed explanation, together with a proposed
fix, after I check it all in detail.
This applies to some other patches in this series as well.
I assume this is specifically about the migration to
rockchip_early_misc_init_r?
What's the issue? And for which devices?
I don't really need this patch, it's just to avoid code duplication in a
later patch but I'd rather not have this block this patch series. We can
always revisit this in a separate patch series which can take as long as
we want.
Cheers,
Quentin
