On 2024-02-07 08:53, Matwey V. Kornilov wrote: > ср, 7 февр. 2024 г. в 03:14, Jonas Karlman <jo...@kwiboo.se>: >> >> Update defconfig for rk3328-rock64 with new defaults. >> >> Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. > > What is abould rockchip-efuse?
The efuse driver is only used in U-Boot proper to read cpuid for serial# and ethaddr use, there is nothing trying to access efuse in TPL or SPL. Beside the initialization of efuse block done after commit 5708e8eeae53 ("rockchip: rk3328: Set efuse auto mode and timing control"). But that happens outside the efuse driver, in arch_cpu_init() at SPL. So it is safe to skip DRIVERS_MISC for TPL/SPL and current intended use of efuse still continues to work. Regards, Jonas > >> >> Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash >> of FIT images. This help indicate if there is an issue loading any of >> the images to DRAM or SRAM. Also add LEGACY_IMAGE_FORMAT=y to keep >> support for scripts. >> >> Remove the NET_RANDOM_ETHADDR=y option, ethaddr and eth1addr is set >> based on cpuid read from eFUSE. >> >> Add SPL_DM_SEQ_ALIAS=y option to use alias sequence number in SPL. >> >> Add DM_ETH_PHY=y and PHY_REALTEK=y to support onboard ethernet PHY. >> >> Also add missing device tree file to MAINTAINERS and add myself as a >> reviewer for this board. >> >> Signed-off-by: Jonas Karlman <jo...@kwiboo.se> >> --- >> board/rockchip/evb_rk3328/MAINTAINERS | 2 ++ >> configs/rock64-rk3328_defconfig | 7 +++++-- >> 2 files changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/board/rockchip/evb_rk3328/MAINTAINERS >> b/board/rockchip/evb_rk3328/MAINTAINERS >> index dc750bd69426..419bc8ded375 100644 >> --- a/board/rockchip/evb_rk3328/MAINTAINERS >> +++ b/board/rockchip/evb_rk3328/MAINTAINERS >> @@ -47,8 +47,10 @@ F: arch/arm/dts/rk3328-roc-cc-u-boot.dtsi >> >> ROCK64-RK3328 >> M: Matwey V. Kornilov <matwey.korni...@gmail.com> >> +R: Jonas Karlman <jo...@kwiboo.se> >> S: Maintained >> F: configs/rock64-rk3328_defconfig >> +F: arch/arm/dts/rk3328-rock64.dts >> F: arch/arm/dts/rk3328-rock64-u-boot.dtsi >> >> ROCKPIE-RK3328 >> diff --git a/configs/rock64-rk3328_defconfig >> b/configs/rock64-rk3328_defconfig >> index 0297d098761e..0157a1efe374 100644 >> --- a/configs/rock64-rk3328_defconfig >> +++ b/configs/rock64-rk3328_defconfig >> @@ -15,7 +15,6 @@ CONFIG_ROCKCHIP_RK3328=y >> CONFIG_TPL_ROCKCHIP_COMMON_BOARD=y >> CONFIG_TPL_LIBCOMMON_SUPPORT=y >> CONFIG_TPL_LIBGENERIC_SUPPORT=y >> -CONFIG_SPL_DRIVERS_MISC=y >> CONFIG_SPL_STACK_R_ADDR=0x600000 >> CONFIG_SPL_STACK=0x400000 >> CONFIG_TPL_SYS_MALLOC_F_LEN=0x800 >> @@ -26,7 +25,9 @@ CONFIG_DEBUG_UART=y >> # CONFIG_ANDROID_BOOT_IMAGE is not set >> CONFIG_FIT=y >> CONFIG_FIT_VERBOSE=y >> +CONFIG_SPL_FIT_SIGNATURE=y >> CONFIG_SPL_LOAD_FIT=y >> +CONFIG_LEGACY_IMAGE_FORMAT=y >> CONFIG_DEFAULT_FDT_FILE="rockchip/rk3328-rock64.dtb" >> # CONFIG_DISPLAY_CPUINFO is not set >> CONFIG_DISPLAY_BOARDINFO_LATE=y >> @@ -57,8 +58,8 @@ CONFIG_TPL_OF_PLATDATA=y >> CONFIG_ENV_IS_IN_MMC=y >> CONFIG_SYS_RELOC_GD_ENV_ADDR=y >> CONFIG_SYS_MMC_ENV_DEV=1 >> -CONFIG_NET_RANDOM_ETHADDR=y >> CONFIG_TPL_DM=y >> +CONFIG_SPL_DM_SEQ_ALIAS=y >> CONFIG_REGMAP=y >> CONFIG_SPL_REGMAP=y >> CONFIG_TPL_REGMAP=y >> @@ -76,6 +77,8 @@ CONFIG_ROCKCHIP_EFUSE=y >> CONFIG_MMC_DW=y >> CONFIG_MMC_DW_ROCKCHIP=y >> CONFIG_SPI_FLASH_GIGADEVICE=y >> +CONFIG_PHY_REALTEK=y >> +CONFIG_DM_ETH_PHY=y >> CONFIG_ETH_DESIGNWARE=y >> CONFIG_GMAC_ROCKCHIP=y >> CONFIG_PHY_ROCKCHIP_INNO_USB2=y >> -- >> 2.43.0 >> > >