Hi Sean, On 07/02/24 11:14 pm, Sean Anderson wrote: > On 1/30/24 01:26, MD Danish Anwar wrote: >> The fs-loader driver reads env storage_interface and uses it to load >> firmware file into memory using the medium set by env. Update the driver >> to use env fw_storage_interface as this variable is only used to load >> firmwares. The env storage_interface will act as fallback so that the >> existing implementations do not break. >> >> Also update the FS Loader documentation accordingly. > > So why do you want to do this? I don't see what the point of renaming the > variable is, since you are not e.g. adding any new functionality, and we > have to pay for the rename in code size. >
I am upstreaming TI's ICSSG driver for u-boot and during code review Roger Quadros <rog...@kernel.org> commented asking to rename this variable [1]. I think the motive here was to keep all variables used by fs-loader driver with 'fw_' prefix. All other variables had 'fw_' prefix except for storage_interface. [1] https://lore.kernel.org/all/4721f3b9-f823-47f3-b4f3-ed40002af...@kernel.org/ > --Sean -- Thanks and Regards, Danish