Hey Bryan! On 12/02/24 20:51, Bryan Brattlof wrote: > Hey Aradhya! > > On February 12, 2024 thus sayeth Aradhya Bhatia: >> Refactor common QoS code into a new common header file, and the soc >> specific setup_qos functions into a common API. >> >> Rename $(soc)_qos_count and $(soc)_qos_data variables to qos_count and >> qos_data. When QoS settings of more SoCs are added, only one pair will >> be defined at a time, based on the config SOC_K3_$(soc). >> >> This refactoring has been done for 2 major purposes. >> >> - The auto-generated $(soc)_qos_data.c and $(soc)_qos.h files cannot >> have any code that is specific to any bootloader. Those files have to >> remain agnostic of different bootloader implementations and their >> header files. >> >> - The existing implementation was less than ideal and would have enabled >> multiple $(soc)_qos_count and $(soc)_qos_data variables for all SoC >> variants. >> >> Signed-off-by: Aradhya Bhatia <a-bhat...@ti.com> >> --- >> >> Change Log: >> >> - new in v2: >> - Move K3_QOS config to the r5/Kconfig. >> >> Previous versions: >> >> - v1: >> https://lore.kernel.org/all/20240206085610.3226136-1-a-bhat...@ti.com/ >> > > ... > >> diff --git a/arch/arm/mach-k3/r5/am62ax/Makefile >> b/arch/arm/mach-k3/r5/am62ax/Makefile >> index 02a941805e9a..e4e55ce5c7dd 100644 >> --- a/arch/arm/mach-k3/r5/am62ax/Makefile >> +++ b/arch/arm/mach-k3/r5/am62ax/Makefile >> @@ -4,4 +4,4 @@ >> >> obj-y += clk-data.o >> obj-y += dev-data.o >> -obj-y += am62a_qos_data.o >> +obj-y += am62a_qos_uboot.o > > No objections from me though I am curious about the name change. Was > there an issue with using the original am62a_qos_data.c >
Yes! The previous version of the auto-generated file ($soc_qos_data.c) was the same for u-boot and SBL, which restricted us from making u-boot specific changes. We will now be creating 2 different files for each of them, and the name had to be changed to reflect that. Regards Aradhya