On Sun, Feb 18, 2024 at 9:12 PM Fabio Estevam <feste...@gmail.com> wrote: > > On Sun, Feb 18, 2024 at 10:39 PM Fabio Estevam <feste...@gmail.com> wrote: > > > > Hi Jesse, > > > > On Sun, Feb 18, 2024 at 6:20 PM Jesse Taube <mr.bossman...@gmail.com> wrote: > > > > > > Enable binman in Kconfig and in device tree. > > > > Please explain the rationale for doing this.
Rationale for using binman is running mkimage will generate a file named fspi_header.bin which needs to be prepended to SPL and u-boot.img with padding. This is how the imx8mm_evk did it. > Also, it seems that this patch alone does not do anything useful. No, it doesn't but it makes the next patch smaller and keeps the changes to do only one thing. I separated it as it can be separated into two distinct tasks. > Shouldn't this patch be squashed with the next one? yes, it can be. > Then you could explain in the commit log that you are using binman to > generate the binary that is suited for booting from SPI NOR flash. Shall I send a V4 with them squashed then? > Do you agree? Either way works for me. Sorry for being a nuisance. Thanks, Jesse
