On 20/02/2024 08:37, Marek Vasut wrote: > This hs400_tuning is a flag, make it bool. No functional change. > This will be useful in the following patch, which adds another > more generic flag, where the compiler can better use the space > now reserved for the u8 to store more flags in it.
The minimum size for a bool is one byte so there likely won't be any improvement in struct size from using bool instead of u8 for `hs400_tuning` here and `tuning` added in the next patch. I still think it's a good change to make though, bool is the right type for an on/off flag. So I think the commit message needs a little clarification. Other than that, Reviewed-by: Paul Barker <paul.barker...@bp.renesas.com> Tested-by: Paul Barker <paul.barker...@bp.renesas.com> (tested on RZ/G2L with commit ad50a8151387 from https://source.denx.de/u-boot/custodians/u-boot-sh) Thanks, -- Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature