On 2/21/24 08:25, Janne Grunau via B4 Relay wrote:
From: Janne Grunau <j...@jannau.net>

Discovered while trying to use the second interface in the USB keyboard
driver necessary on Apple USB keyboards.

Signed-off-by: Janne Grunau <j...@jannau.net>
---
  drivers/usb/host/xhci-ring.c | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index b60661fe05..4446f5f098 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -685,6 +685,9 @@ int xhci_bulk_tx(struct usb_device *udev, unsigned long 
pipe,
                reset_ep(udev, ep_index);
ring = virt_dev->eps[ep_index].ring;
+       if (!ring)
+               return -1;

Would it make sense to return e.g. -EINVAL or some other errno ?

Reply via email to