Hi Trevor, On 2024-03-05 03:10, Trevor Woerner wrote: > Following the pattern of other Rockchip devices, enable the U-Boot environment > to be stored in MMC. This patch specifically assumes the environment will be > stored on the SDcard.
This board support optional emmc (sd nand), forcing env to sd-card does not sound like a good idea, ideally the env is stored in the media where TPL/SPL is running from. Please note that booting from emmc is not working in current state, I have an incoming series to improve support for this and other rk3308 boards. Hoping to have it on list later this week, see [1] for current work-in-progress patches. It enables full support for usb otg/host, ums, rockusb, emmc/sd nand, ethernet, ethaddr from serial#, rnd and fit checksum validation on this board (tested on a v1.3 board). [1] https://github.com/Kwiboo/u-boot-rockchip/commits/rk3308-2024.04 Regards, Jonas > > Signed-off-by: Trevor Woerner <twoer...@gmail.com> > --- > configs/rock-pi-s-rk3308_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configs/rock-pi-s-rk3308_defconfig > b/configs/rock-pi-s-rk3308_defconfig > index 9908a4b4f457..af2cddcc2553 100644 > --- a/configs/rock-pi-s-rk3308_defconfig > +++ b/configs/rock-pi-s-rk3308_defconfig > @@ -54,7 +54,9 @@ CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=64 > CONFIG_SPL_OF_CONTROL=y > CONFIG_OF_LIVE=y > CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names > interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents" > +CONFIG_ENV_IS_IN_MMC=y > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > +CONFIG_SYS_MMC_ENV_DEV=1 > CONFIG_REGMAP=y > CONFIG_SYSCON=y > CONFIG_CLK=y