Re: [PATCH 1/2] sandbox: select CONFIG_64BIT for SANDBOX64

[Heinrich Schuchardt]

On 3/5/24 16:16, Dan Carpenter wrote:

Select CONFIG_64BIT so that we pass the -m64 option (instead of -m32) to
static analysis tools.

Signed-off-by: Dan Carpenter <dan.carpen...@linaro.org>
---
  arch/sandbox/Kconfig | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/sandbox/Kconfig b/arch/sandbox/Kconfig
index 0ce77de2fcb4..c431da60e8c4 100644
--- a/arch/sandbox/Kconfig
+++ b/arch/sandbox/Kconfig
@@ -12,6 +12,7 @@ config SYS_CPU

  config SANDBOX64
        bool "Use 64-bit addresses"
+       select 64BIT

SANDBOX64 seems only to control the size of phys_addr_t, phys_size_t,
dma_addr_t.

Please, have a look at symbol SANDBOX_BITS_PER_LONG. It is controlled by
HOST_64BIT, not by SANDBOX64. Isn't this closer related to the -m32/-m64
choice?

Best regards

Heinrich

        select PHYS_64BIT
        depends on HOST_64BIT