On 18:47-20240306, Kumar, Udit wrote:
>
> On 3/6/2024 12:07 PM, Aniket Limaye wrote:
> > - Add the missing bootph-all property in the flash subnode for ospi
> > - Add the missing overrides for the ospi node in the r5 devicetree
>
> Please see , if you can add more on this why we are adding this
>
> also, if this patch fixes some previous commit
>
> >
> > Signed-off-by: Aniket Limaye <a-lim...@ti.com>
> > ---
> > arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi | 4 ++++
> > arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 5 +++++
> > 2 files changed, 9 insertions(+)
> >
> > diff --git a/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi
> > b/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi
> > index 60ca6d21ab..c9fee0ea99 100644
> > --- a/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi
> > +++ b/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi
> > @@ -195,6 +195,10 @@
> > &ospi0 {
> > bootph-all;
You should only use bootph-all property in leaf nodes - at least for
kernel world.
> > +
> > + flash@0 {
> > + bootph-all;
> > + };
> > };
>
>
> Ideally this should come from kernel DT sync or with OF_UPSTREAM, whatever
> is applicable
>
> As you are fixing broken OSPI boot.
>
> Tom can suggest, if he is ok to pull in this fix for 2024.04 or we need to
> wait to get this change into kernel first.
Send this change for upstream kernel right away please.
>
>
> > &serdes_ln_ctrl {
> > diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts
> > b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts
> > index 018faaa13b..195637a836 100644
> > --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts
> > +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts
> > @@ -83,3 +83,8 @@
> > &wkup_vtm0 {
> > bootph-pre-ram;
> > };
> > +
> > +&ospi0 {
> > + reg = <0x0 0x47040000 0x0 0x100>,
> > + <0x0 0x50000000 0x0 0x8000000>;
> > +};
>
> With change in commit message,
>
> Reviewed-by: Udit Kumar <u-kum...@ti.com>
>
>
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5
849D 1736 249D
