Dear Luca Ceresoli, In message <4d9e12b7.2040...@comelit.it> you wrote: > > I'm going to define the bit values for the GPMC_CONFIGn registers. > Is arch/arm/include/asm/arch-omap3/omap_gpmc.h the correct place?
I think so, but I'm not an OMAP expert. Sandeep? > > Is this the correct machine ID? "OMAP3_CPS" does not really relate to > > the board name, "DIG297" ? > As per our previous discussion (see the bottom of > http://lists.denx.de/pipermail/u-boot/2011-March/088964.html), I renamed the > board everywhere except for the Machine ID in the ARM registry, and > consequently mach-types.h. > As you suggested, I plan to ask for a rename in the registry just after this > patch series is integrated in U-Boot, to avoid confusion. The rename in > mach-types.h and in my code would follow. Ah, now I remember. OK. > > Incorrect multiline comment style, please fix globally. > Do you mean like this? > > - /* GPIO list > + /* > + * GPIO list Yes. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The more complex the mind, the greater the need for the simplicity of play. -- Kirk, "Shore Leave", stardate 3025.8 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
