On Fri, Mar 8, 2024 at 11:50 AM Sam Protsenko <semen.protse...@linaro.org> wrote: > > On Fri, Mar 8, 2024 at 11:00 AM Colin McAllister > <colin.mcallis...@garmin.com> wrote: > > > > Currently, setting CONFIG_AB_BACKUP_OFFSET in a target's defconfig will > > not actually enable the #if protected code in android_ab.c. This is > > because "CONFIG_" should have been prepended to the config macro, or the > > macros defined in kconfig.h could have been used. > > > > The code included by ANDROID_AB_BACKUP_OFFSET has been refactored to no > > longer be conditionally compiled by preprocessor conditionals and > > instead use C conditionals. This better aligns with the Linux kernel > > style guide. > > > > Fixes: 3430f24bc6 ("android_ab: Try backup booloader_message") > > Signed-off-by: Colin McAllister <colin.mcallis...@garmin.com> > > Cc: Joshua Watt <jpewhac...@gmail.com> > > Cc: Simon Glass <s...@chromium.org> > > --- > > v2: > > - Replaced #if conditionals with C if conditionals > > - Opted to use CONFIG_ANDROID_AB_BACKUP_OFFSET directly instead of > > macros in kconfig.h as CONFIG_ANDROID_AB_BACKUP_OFFSET is not a > > boolean or tristate value and doesn't have different values when > > building SPL or TPL. > > v3: > > - Added "Fixes:" tag > > Can you please also address my comment about CONFIG_IS_ENABLED() in > the previous mail? It might be just an answer if you think there are > no issues with that, not necessarily v4. >
Ok, I just saw your reply in patch #0. Given that you tested that this change doesn't break any other boards/configuration (e.g. when the mentioned config is not defined), feel free to add: Reviewed-by: Sam Protsenko <semen.protse...@linaro.org> > [snip]