On Mon, Mar 11, 2024 at 04:14:04PM +0100, Michal Simek wrote: > > > On 3/11/24 16:09, Tom Rini wrote: > > On Mon, Mar 11, 2024 at 03:52:57PM +0100, Michal Simek wrote: > > > > > > > > > On 3/11/24 15:39, Tom Rini wrote: > > > > On Mon, Mar 11, 2024 at 02:40:59PM +0530, Love Kumar wrote: > > > > > Hi, > > > > > > > > > > On 11/03/24 2:11 pm, Angelo Dureghello wrote: > > > > > > Hi, > > > > > > > > > > > > jfyi, > > > > > > > > > > > > reset support added in qemu > > > > > > merged as commit d3c79c3974. > > > > > > > > > > > > Regards, > > > > > > angelo > > > > > > > > > > > The other issue was with echo commands: > > > > > => echo $modeboot > > > > > $modeboot > > > > > > > > > > => echo $? > > > > > $? > > > > > > > > > > Does HUSH shell is enabled by default for this? > > > > > > > > It is not, so at least the saveenv test needs to depend on HUSH_PARSER > > > > too. > > > > > > Based on logs on this platform echo $? doesn't return any value. > > > There is any config for it which is not enabled for this platform. > > > Do you know which Kconfig symbol it is? > > > > > > Depending on HUSH is likely big hammer but I was not able to find that > > > exact > > > Kconfig symbol just for $? > > > > Well, if we don't have the hush parser we have a much more limited > > parser enabled and I bet that's why (I think there's no variable > > expansion). > > ok. Then this test should be limited to HUSH too based on how it is written. > I think it should be okish limitation and if someone wants to test it on > systems without HUSH enabled it should just update it. If is fine for you?
Yup, sounds good. And I'll take the next iteration of this test patch when I also grab the patch I posted to cherry-pick the missing reset functionality in our QEMU. -- Tom
signature.asc
Description: PGP signature