Re: [PATCH v3 5/7] efi_selftest: Add box drawing character selftest

[Heinrich Schuchardt]

On 3/16/24 22:50, Janne Grunau via B4 Relay wrote:

From: Andre Przywara <andre.przyw...@arm.com>

UEFI applications rely on Unicode output capability, and might use that
for drawing pseudo-graphical interfaces using Unicode defined box
drawing characters.

Add a simple test to display the most basic box characters, which would
need to be checked manually on the screen for correctness.

Signed-off-by: Andre Przywara <andre.przyw...@arm.com>
Suggested-by: Heinrich Schuchardt <xypron.g...@gmx.de>
Signed-off-by: Janne Grunau <j...@jannau.net>
---
  lib/efi_selftest/efi_selftest_textoutput.c | 20 ++++++++++++++++++++
  1 file changed, 20 insertions(+)

diff --git a/lib/efi_selftest/efi_selftest_textoutput.c 
b/lib/efi_selftest/efi_selftest_textoutput.c
index 917903473d..b56fd2ab76 100644
--- a/lib/efi_selftest/efi_selftest_textoutput.c
+++ b/lib/efi_selftest/efi_selftest_textoutput.c
@@ -46,6 +46,20 @@ u"U+03BB \u03BB - Greek small letter lambda\n"
  u"U+03C2 \u03C2 - Greek small letter final sigma\n"
  u"U+1F19 \u1F19 - Greek capital letter epsilon with dasia\n";

+       const u16 boxes[] =
+u"This should render as four boxes with text\n"
+u"\u250c\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500"
+u"\u2500\u2500\u2500\u252c\u2500\u2500\u2500\u2500\u2500\u2500\u2500"
+u"\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2510\n\u2502"
+u" left top    \u2502 right top     \u2502\n\u251c\u2500"
+u"\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500"
+u"\u2500\u253c\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500"
+u"\u2500\u2500\u2500\u2500\u2500\u2500\u2524\n\u2502 "
+u"left bottom \u2502 right bottom  \u2502\n\u2514\u2500\u2500\u2500"
+u"\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2534"
+u"\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500"
+u"\u2500\u2500\u2500\u2500\u2518\n";

Please, indent the strings by two tabs.

Otherwise:

Reviewed-by: Heinrich Schuchardt <xypron.g...@gmx.de>

+
        /* SetAttribute */
        efi_st_printf("\nColor palette\n");
        for (foreground = 0; foreground < 0x10; ++foreground) {
@@ -140,6 +154,12 @@ u"U+1F19 \u1F19 - Greek capital letter epsilon with 
dasia\n";
                return EFI_ST_FAILURE;
        }
        efi_st_printf("\n");
+       ret = con_out->output_string(con_out, boxes);
+       if (ret != EFI_ST_SUCCESS) {
+               efi_st_error("OutputString failed for box drawing chars\n");
+               return EFI_ST_FAILURE;
+       }
+       efi_st_printf("\n");

        return EFI_ST_SUCCESS;
  }