On Thu, Apr 11, 2024 at 07:37:27PM -0400, Greg Malysa wrote: > > This series adds support for the ADI SC5xx machine type and includes two > core drivers that are required for being able to boot any board--a UART > driver and the clock tree driver. Our corresponding Linux support relies > on u-boot configuring the clocks correctly before booting, so it is not > possible to boot any board without the CGU/CDU configuration happening > here. The clock tree itself is only used by the UART in this minimal > patch set, but is of course broadly useful for all other peripheral > drivers to be submitted in future patch sets. There are also no board > files or defconfigs included here, but some common definitions that will > be used to build board files currently are. > > Some of the configuration code in dmcinit and clkinit is quite scary and > causes a lot of checkpatch violations. It is modified from code > initially provided by ADI, but it has not been fully rewritten. There's > a question of how important it is to clean up this code--it has some > quality violations, but it has been in use (including in production) for > over two years and is known to work for performing the low level SoC > initialization, while a rewrite might introduce bugs that could take a > significant amount of time to detect in the future. > > Please provide any feedback or comments that will be helpful in creating > a v2 of this patch that will be ready to submit for inclusion into the > main tree, as well as general observations that we should consider in > other driver patches before submitting them.
Does this series pass CI currently? Thanks. -- Tom
signature.asc
Description: PGP signature