On Fri, May 17, 2024 at 05:15:34PM +0200, Heinrich Schuchardt wrote:

> make mrproper should remove all build artefacts.
> 
> Running make tests without deleting build-sandbox led to an error
> 
>     *** No rule to make target '../include/common.h',
>     needed by 'include/config/auto.conf'.
> 
> on my machine.
> 
> Let's add the build-sandbox*/ directories to the mrproper target.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I don't believe it's the right place to remove build directories. This
is also incomplete as it wouldn't clean up other platforms that can be
built, and of course it cannot handle out of tree build directories. All
build directories regardless of where they are need to be removed as
that particular change breaks re-using build directories before/after
it.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to