On Mon, 20 May 2024 at 04:17, Tom Rini <tr...@konsulko.com> wrote: > > On Sun, May 19, 2024 at 09:57:03PM +0100, Jiaxun Yang wrote: > > > > > > 在2024年5月19日五月 下午7:20，Daniel Schwierzeck写道： > > > > > > Reviewed-by: Daniel Schwierzeck <daniel.schwierz...@gmail.com> > > > > > Hi Daniel, > > > > Thanks for reviewing the series. > > > > > [...] > > > > > > should be 'select' because the switch to upstream DTS is permanent and > > > it does not make sense for the user to be able to deselect this option > > > > > > > Do you want me to send another version or are you going to fix > > it as you apply the patch? > > So, in the case of OF_UPTREAM, it's "imply OF_UPSTREAM" everywhere else > and while there's a case to be made it should be select instead, that's > probably a future clean-up for all users.
I think it depends on whether OF_UPSTREAM is enabled for a SoC (with multiple board variants) or a single target board (I suppose that's the case here). For the former case, "imply" would be preferred since we can't enforce a policy at SoC level where new boards are coming up which have to opt out of OF_UPSTREAM. For the latter case, "select" would be preferred. However, I agree that it can be a future cleanup patch. -Sumit > > -- > Tom
